Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hashing Function #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peyton-lucas
Copy link

##What is this change?
This PR upgrades crypto hashing function of this application to make it compatible with the most current version of Node.js

##Why is this change necessary?
The current state of the application will only build with Node versions <=16. These minimal changes update webpack, so it can successfully build and run this application with the latest version(s) of NodeJS - currently 20.2.0.

##Does your change need a Changelog entry?
Yes.

Refactored webpack config file to use most current Node.js crypto hashing function to allow app to build and run with current version(s) of Node.

##Do you need clarification on anything?
No

##Were there any complications while making this change?
No

##Have you reviewed and updated the documentation for this change? Is new documentation required?
No new documentation is required for these changes.

Users can now successfully build the application with both current and deprecated Node versions following the same existing documentation.

##How did you verify this change?
NOTE: Successfully tested with Node 15.14.0, 16.20.1 and 20.2.0 using a locally hosted Sensu Go backend running in a docker container. All elements of frontend react app were properly functioning.

To verify this change, follow these steps:

Verify application does not work with Node 20.2.0
a) Switch to master branch
b) Update local version of nodeJS within 14 - 16 (use NVM or preferred version manager)
c) Attempt to build application (should successfully build and launch)
d) Switch to node version >=17 (preferably 20.2.0 - most current stable release) and attempt to build application(should fail)

Verify application does work with Node 20.2.0
a) Switch to branch upgrade-hashing-function
b) Update local version of nodeJS to 20.2.0 (use NVM or preferred version manager)
c) c) Attempt to build application (should successfully build and launch)

… current version of Node.js

Signed-off-by: peyton-lucas <[email protected]>
Copy link

@acrawly acrawly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tested these changes and find them successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants